Getting Started

Playlist

We know that Code Reviews are a Good Thing. We probably have our own personal lists of things we look for in the code we review, while also fearing what others might say about our code. How do we ensure that code reviews are actually benefiting the team, and the application? How do we decide who does the reviews? What does "done" look like?

In this webinar recording, Trisha identifies some best practices to follow. She talks about what's really important in a code review and sets out some guidelines to follow in order to maximize the value of the code review and minimize the pain.

0:00 Introduction: Reading other people's code is hard
5:21 What to look for in a code review
6:37 Different code review workflows
8:42 One Size Does Not Fit All
9:01 Code Review anti-patterns
18:49 Why perform code reviews?
23:07 When do you review code?
24:37 Who is involved in the review?
26:39 Audience questions
31:36 Where do you perform the review?
36:53 What do you look for in a code review?
42:01 How do you perform the review?
51:26 Summary
53:40 Audience Questions

About the Presenter
Trisha Gee has developed Java applications for a range of industries, including finance, manufacturing, software and non-profit, for companies of all sizes. She has expertise in Java high performance systems, is passionate about enabling developer productivity, and dabbles with Open Source development. Trisha is a Java Champion and is a Developer Advocate for Upsource and IntelliJ IDEA.
58:47
Code Review Best Practices
16.10.2018
In this screencast we’re outlining some of the best practices that apply to performing code reviews. The practices themselves are tool agnostic, but here we see how they can be applied in Upsource (https://www.jetbrains.com/upsource/). We'll look at the things that should not be in a code review, we’ll talk about various possible goals teams can have for their code review process, and of course we’ll dive deeper in the code review process itself. 

Here’s a short summary: 
00:05 Automate everything you can
01:02 Agree on code review goals
02:15 Submitting for review
04:09 Reviewing code
05:50 Iterating
09:13 Closing the review
10:34 Summary

In our blog you’ll find this video’s transcript and links to further information: https://blog.jetbrains.com/upsource/2018/08/30/code-review-best-practices/. Want to learn more about code review? Check out our series of articles on code review practices and “what to look for in a code review”: https://blog.jetbrains.com/upsource/category/practices/.  

By Trisha Gee
Developer Advocate at JetBrains
12:11
Code Review Best Practices
29.08.2018
Upsource is a powerful tool for teams wishing to improve their code, projects and processes. It serves as a polyglot code review tool, a source of data-driven project analytics, an intelligent repository browser and a team collaboration center. Upsource boasts in-depth knowledge of Java, PHP, JavaScript, Python, and Kotlin to increase the efficiency of code reviews. It continuously analyzes the repository activity providing a valuable insight into potential design problems and project risks. On top of that Upsource makes team collaboration easy and enjoyable.
http://jetbrains.com/upsource/
05:45
Upsource Overview
28.07.2017
Watch a short overview of the new features brought by Upsource 2017.1. More details:https://www.jetbrains.com/upsource/whatsnew/
02:57
What's New in Upsource 2017.1
21.02.2017
Gary Hockin explores PHP code insight features in Upsource. 

JetBrains Upsource is a smart code review tool and a repository browser that supports Git, Mercurial, Subversion and Perforce. 
It is the only code review tool that deeply understands your code and offers static code analysis and code-aware navigation in web UI for projects written in Java, PHP, JavaScript and/or Kotlin. 
To learn more about Upsource, please visit http://jetbrains.com/upsource/
04:04
PHP code insight in Upsource
14.11.2016
This webinar shows how going through a code review became much easier and enjoyable in Tallink's team of five developers working on a mobile web booking system.

The following topics are covered:
0:02 Introduction
2:15  How code review was done before discovering Upsource
6:15  Current setup
9:11 Code review using Upsource web interface and IntelliJ IDEA Upsource integration
28:52 Q&A

The session is geared towards developers of different proficiency regardless of programming language of choice.

Learn more about Upsource at https://www.jetbrains.com/upsource/.
38:35
Code Review with Upsource at Tallink
03.06.2016
Reviewing your teammates' code changes outside of an IDE may feel uncomfortable and even frustrating, but there's another way.

In this webinar you’ll learn how to create code reviews, assign reviewers, participate in discussions and manage your code reviews straight from your favorite IDE using Upsource IDE Integration plugin.

The following topics are covered:
0:26 Quick look at Upsource’s web UI
3:43 Code Review in IDE
4:30 Upsource plugin for IDE 
4:50 Setup: installing and configuring the plugin
6:40 Code review workflow with the plugin
8:10 Starting a code review from the Commit Dialog
9:35 Having a code review assigned to you
9:55 The Reviews window
11:50 Reviewing a change, leaving comments in the code
16:40 Adding a code review level comment
20:30 Back to code author to address reviewer’s concerns
22:50 Different ways to add a commit to a code review
23:50 Reviewing recent changes and accepting a review
25:35 Additional Upsource Integration plugin features
28:25 GitHub integration
30:30 Upsource web UI features
34:25 Q&A

The session is geared towards developers of different proficiency regardless of programming language of choice.

Learn more about Upsource at https://www.jetbrains.com/upsource/.
49:12
Peer Code Review from IDE
27.09.2016
JetBrains Upsource is a smart code review tool and a repository browser that supports Git, Mercurial, Subversion and Perforce. 
It is the only code review tool that deeply understands your code and offers static code analysis and code-aware navigation in web UI for projects written in Java, PHP, JavaScript and/or Kotlin. 
This video gives an overview of Upsource. To learn more about Upsource, please visit http://jetbrains.com/upsource/
03:39
JetBrains Upsource Overview: code review tool with code insight
15.04.2016
Trisha Gee gives an overview of the basic code review workflow in Upsource. 

Check out http://jetbrains.com/upsource/ to find out more about JetBrains Upsource.
04:47
Code review workflow in Upsource
09.06.2015
Trisha Gee gives an overview of the features available in Upsource plugin for IntelliJ IDEA and other JetBrains IDEs. 

Check out http://jetbrains.com/upsource/ to find out more about JetBrains Upsource.
03:34
Upsource plugin for JetBrains IDEs
01.06.2015
https://www.jetbrains.com/upsource/features/java.html JetBrains Upsource is an on-premises repository browser and code review tool that supports Git, Mercurial, Subversion and Perforce. This video gives a brief overview of Upsource features and shows its Java-specific functionality such as server-side code inspections, code navigation and search.
02:34
Advanced Java support in JetBrains Upsource
09.12.2014
https://www.jetbrains.com/upsource/features/code_review.html JetBrains Upsource is an on-premises repository browser and code review tool that supports Git, Mercurial, Subversion and Perforce. This video shows how Upsource can be used to discuss changes in a project and create code reviews on individual revisions or entire branches.
03:00
Code review with JetBrains Upsource
09.12.2014
https://www.jetbrains.com/upsource/features/ JetBrains Upsource is an on-premises repository browser and code review tool that supports Git, Mercurial, Subversion and Perforce. This video shows how Upsource works as a code browser, helping keep track of changes in a project and read code as of a particular revision.
02:38
Browsing repositories with JetBrains Upsource
09.12.2014